Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci/gha: add go-fix job #4332

Merged
merged 1 commit into from
Jul 5, 2024
Merged

ci/gha: add go-fix job #4332

merged 1 commit into from
Jul 5, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jul 1, 2024

Add a CI job to ensure go fix produces no result. Quoting go doc cmd/fix:

Fix finds Go programs that use old APIs and rewrites them to use newer
ones. After you update to a new Go release, fix helps make the
necessary changes to your programs.

As expected, the job fails before #4329 is merged.

@kolyshkin kolyshkin force-pushed the fix-tags branch 2 times, most recently from 63e5062 to a2820e0 Compare July 1, 2024 17:17
@kolyshkin kolyshkin changed the title [test] ci/gha: add go-fix job ci/gha: add go-fix job Jul 1, 2024
@kolyshkin kolyshkin marked this pull request as ready for review July 1, 2024 17:20
@kolyshkin kolyshkin requested a review from thaJeztah July 1, 2024 17:25
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - curious if this is something golangci-lint can also provide?

@kolyshkin
Copy link
Contributor Author

LGTM - curious if this is something golangci-lint can also provide?

The first thing I checked. For some reason, it's not there.

Add a CI job to ensure go fix produces no result. Quoting
`go doc cmd/fix`:

> Fix finds Go programs that use old APIs and rewrites them to use newer
> ones. After you update to a new Go release, fix helps make the
> necessary changes to your programs.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@lifubang lifubang merged commit 8a324d6 into opencontainers:main Jul 5, 2024
40 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants